Possible logic error...

This is from stock Scrip_AI_Orders_Ships.txt. From the function Send_Ship_To_Join_Fleet:

if (Sys_Is_Empire_Fleet_Waiting_For_Ships(sys_long_Player_ID, fleet_id)) then
        if (not Is_Enemy_Present_At_Location(fleet_sys_loc, fleet_sect_loc)) then
          set this_dist := Sys_Get_Hex_Distance_Between_Sectors(sys_long_Player_ID, ship_sys_loc, ship_sect_loc, fleet_sys_loc, fleet_sect_loc)
          if (this_dist < min_dist) then
            set min_dist := this_dist
            set move_sys_loc := fleet_sys_loc
            set move_sect_loc := fleet_sect_loc
            set move_fleet_id := fleet_id
          endif
        endif
      endif
...
    call Sys_Give_Space_Object_Order_MoveTo(ship_id, move_sys_loc, move_sect_loc)
    call Sys_Give_Space_Object_Order_Join_Fleet(ship_id, move_fleet_id, task_force_id, task_force_role)
...

From the function Give_Specific_Fleet_Orders:

  if (not orders_given) then
    if (ships_joining_this_fleet > 0) and (ship_count <= (ships_per_fleet * 0.50)) then
      call Sys_Set_Empire_Fleet_Waiting_For_Ships(sys_long_Player_ID, fleet_id, TRUE)
      set orders_given := TRUE
    endif
  endif

Now check my logic on this (I could be wrong) but the way I read this is: Join this fleet only if this fleet is waiting for ships. Wait for ships only if a ship wants to join this fleet. In other words, they are joining only if something is waiting, but something is waiting only if something is joining. So it never happens...the AI never sends ships to joing existing fleets. Shouldn't it be:

  if (not orders_given) then
    if (ships_joining_this_fleet > 0) or (ship_count <= (ships_per_fleet * 0.50)) then
      call Sys_Set_Empire_Fleet_Waiting_For_Ships(sys_long_Player_ID, fleet_id, TRUE)
      set orders_given := TRUE
    endif
  endif

If I'm right, that little change could help the AI a bit.

Fixed, and a big thank-you to Brand for pointing that out.

"Only by being constantly at war with evil in all things, including yourself, can you truely know peace."
Download my mod here: GidMod

New fleets are set to wait for ships.

Existing fleets follow the code I posted above.

Additional:

Existing fleets use lng_AI_Available_Fleet_Ships_Count to determine how big it should be. That variable has its value reduced by the number of explorers and surveyors, but seems to never be set to a value above zero before this is done (at least, not that I could find). So, fleets never think they have too few ships.

"Only by being constantly at war with evil in all things, including yourself, can you truely know peace."
Download my mod here: GidMod

Weird...my scripts seem to be missing that. At least, the ones I've been modding. I'll have to double check the current stock versions (the ones I've been modding date from a while ago).

"Only by being constantly at war with evil in all things, including yourself, can you truely know peace."
Download my mod here: GidMod

Yep, found the lines for the ship tally in stock. I've imported them in to my mod.

However, the above logic error still exists in stock.

"Only by being constantly at war with evil in all things, including yourself, can you truely know peace."
Download my mod here: GidMod